Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Fix CI check and remove try-runtime command#3046

Merged
paritytech-processbot[bot] merged 5 commits intomasterfrom
oty-fix-try-runtime-check
Aug 23, 2023
Merged

Fix CI check and remove try-runtime command#3046
paritytech-processbot[bot] merged 5 commits intomasterfrom
oty-fix-try-runtime-check

Conversation

@ggwpez
Copy link
Copy Markdown
Member

@ggwpez ggwpez commented Aug 22, 2023 •
edited
Loading

(preparation for the monorepo)

Changes;

@ggwpez
CI: Fix check-try-runtime
b8d7a22 
(preparation for the monorepo)

Warnings should be treated as errors here, since this is how it will
be done in the monorepo.
I expect to see two errors in this check now.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez requested review from a team as code owners August 22, 2023 16:32
@ggwpez ggwpez added B0-silent Changes should not be mentioned in any release notes A3-in_progress Pull request is in progress. No review needed at this stage. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Aug 22, 2023
@ggwpez ggwpez self-assigned this Aug 22, 2023
@ggwpez
Allow deprecated
ebc76b8 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@liamaharon
Copy link
Copy Markdown

liamaharon commented Aug 23, 2023

@ggwpez I just removed the commands from polkadot and substrate clis instead of allowing deprecated. Maybe we can do the same with cumulus?

@ggwpez
Copy link
Copy Markdown
Member Author

ggwpez commented Aug 23, 2023

Ah okay, yes i will change it.

ggwpez added 3 commits August 23, 2023 13:25
@ggwpez
Remove try-runtime command
adad936 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
make it compile
54bc5c9 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Remove try-runtime-cli dependency
0233df5 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez requested a review from liamaharon August 23, 2023 12:27
@paritytech-ci paritytech-ci requested a review from a team August 23, 2023 14:06
@ggwpez ggwpez changed the title [CI] Fix try-runtime check Fix CI check and remove try-runtime command Aug 23, 2023
@ggwpez ggwpez added A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes T0-node This PR/Issue is related to the topic “node”. and removed A3-in_progress Pull request is in progress. No review needed at this stage. B0-silent Changes should not be mentioned in any release notes labels Aug 23, 2023
@ggwpez
Copy link
Copy Markdown
Member Author

ggwpez commented Aug 23, 2023

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 9bdac68 into master Aug 23, 2023
@paritytech-processbot paritytech-processbot bot deleted the oty-fix-try-runtime-check branch August 23, 2023 14:15
@jasl jasl mentioned this pull request Oct 20, 2023
Merged
@crystalin crystalin mentioned this pull request Oct 20, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@liamaharon liamaharon Awaiting requested review from liamaharon

3 more reviewers

@rcny rcny rcny approved these changes

@bkchr bkchr bkchr approved these changes

@altaua altaua altaua approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ggwpez ggwpez

Labels

A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T0-node This PR/Issue is related to the topic “node”.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ggwpez @liamaharon @rcny @bkchr @altaua